refactor: rename status color tokens to --sf-color-{status}-subtle/muted/strong - #23
Merged
Merged
Conversation
…ted/strong
Replaces --sf-status-{status}-{bg|border|text} with the new
--sf-color-{status}-{subtle|muted|strong} convention so all color
tokens share a consistent --sf-color-* prefix.
Tokens remain in core/tokens.css — available without loading
optional/tokens.palette.css.
https://claude.ai/code/session_0115m6d38tanzv2hPVm2Pqju
📝 WalkthroughWalkthroughThis PR refactors the status color token system in the SLASHED CSS framework, replacing the old ChangesStatus Token Refactor
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint skipped: no ESLint configuration detected in root package.json. To enable, add Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@core/tokens.css`:
- Around line 237-270: The change removes public `--sf-status-*` properties and
breaks downstream themes; add temporary deprecated aliases that map each removed
`--sf-status-*` name to the new `--sf-color-*` triplet tokens (e.g. map the old
status variants for success, warning, error, info, danger to the new
--sf-color-*-subtle / --sf-color-*-strong / --sf-color-*-muted tokens used in
core/tokens.css such as --sf-color-success-subtle, --sf-color-success-strong,
--sf-color-success-muted), mark them as deprecated in comments, and keep these
aliases for at least one release before removal so consumers retain backward
compatibility.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 0c3785bd-9074-4abc-9d46-c56e86b0b0ab
⛔ Files ignored due to path filters (1)
dist/slashed.essential.cssis excluded by!**/dist/**
📒 Files selected for processing (4)
core/states.csscore/tokens.cssdocs/demo.htmloptional/tokens.palette.css
This was referenced May 19, 2026
This was referenced Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces --sf-status-{status}-{bg|border|text} with the new
--sf-color-{status}-{subtle|muted|strong} convention so all color
tokens share a consistent --sf-color-* prefix.
Tokens remain in core/tokens.css — available without loading
optional/tokens.palette.css.
https://claude.ai/code/session_0115m6d38tanzv2hPVm2Pqju
Summary by CodeRabbit